Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Key mismatch for expiration date in feature file and implementation #9124

Open
grgprarup opened this issue May 10, 2024 · 0 comments · May be fixed by #9278
Open

[QA] Key mismatch for expiration date in feature file and implementation #9124

grgprarup opened this issue May 10, 2024 · 0 comments · May be fixed by #9278
Assignees
Labels

Comments

@grgprarup
Copy link
Contributor

When (send|create)ing the shares key expirationDateTime is used in the request body.

In the feature file expireDate and expirationDateTime is used

When user "Alice" sends the following resource share invitation using the Graph API:
      | resource        | <resource>               |
      | space           | Personal                 |
      | sharee          | grp1                     |
      | shareType       | group                    |
      | permissionsRole | <permissions-role>       |
      | expireDate      | 2043-07-15T14:00:00.000Z |
And user "Alice" has sent the following resource share invitation:
      | resource           | testfile.txt         |
      | space              | Personal             |
      | sharee             | Brian                |
      | shareType          | user                 |
      | permissionsRole    | Viewer               |
      | expirationDateTime | 2025-07-15T14:00:00Z |

(space share also)

both of the steps use sendShareInvitation and the implementation of sendShareInvitation uses expireDate so the share step with expirationDateTime creates a share without an expiration date as it sends null.

  • Use expirationDateTime for sharing graph API step (feature + implementation)
  • Keep expireDate for sharing API steps (not to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant