Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Assimilate clean command into sessions #9041

Merged
merged 4 commits into from
May 3, 2024
Merged

[full-ci] Assimilate clean command into sessions #9041

merged 4 commits into from
May 3, 2024

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented May 2, 2024 •
edited

Assimilates the clean command into sessions.

Fixes #9003

Changes

  • ocis storage-users uploads list got deprecated (it was before but now it prints it)
  • ocis storage-users uploads clean got deprecated
  • ocis storage-users uploads sessions got new parameters
    • clean cleans listed uploads. It is recommended to run without clean flag first to double check which uploads will be removed
    • has-virus allows filtering for infected files
  • ocis storage-users uploads sessions --json did not output proper json, now it does
  • ocis storage-users upload sessions info string (it prints when run without --json) was completely bonked
    • fixed it
    • added unit tests

Examples

# List all upload sessions
ocis storage-users uploads sessions

# List upload sessions that are currently in postprocessing
ocis storage-users uploads sessions --processing

# List upload sessions that are infected by viruses
ocis storage-users uploads sessions --has-virus

# Clean expired uploads
ocis storage-users uploads sessions --expired --clean

# Clean upload sessions that are not processing and are not virus infected
ocis storage-users uploads sessions --processing=false --has-virus=false --clean

# Restart upload sessions that are currently in postprocessing
ocis storage-users uploads sessions --processing --restart

# Restart one specific upload
ocis storage-users uploads sessions --id=<uploadID> --restart

@update-docs Update Docs
Copy link

update-docs bot commented May 2, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kobergj kobergj marked this pull request as draft May 2, 2024 09:32
@kobergj
feat(storage-users): assimilate clean command into sessions
4941620 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
feat(storage-users): add virusfilter to sessions command
3097a69 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
feat(reva): bump reva
4b6d1f6 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj marked this pull request as ready for review May 2, 2024 12:15
mmattel
mmattel requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@mmattel mmattel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add the change also to the readme, the current session commands are documented and would now no longer be valid.

@kobergj
feat(storage-users): document sessions command
62b1286 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
mmattel
mmattel approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs pov

@kobergj kobergj enabled auto-merge May 3, 2024 08:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
34.2% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarCloud

@kobergj kobergj merged commit b1418fe into owncloud:master May 3, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request May 3, 2024
@kobergj
Merge pull request #9041 from kobergj/ImproveCleanCommand
4aa8164 
[full-ci] Assimilate clean command into sessions
@kobergj kobergj deleted the ImproveCleanCommand branch May 3, 2024 10:05
This was referenced May 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonchaser dragonchaser dragonchaser approved these changes

@mmattel mmattel mmattel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assimilate clean command into sessions
3 participants
@kobergj @dragonchaser @mmattel