Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy folder to received folder #40788

Open
phil-davis opened this issue May 15, 2023 · 4 comments
Open

Copy folder to received folder #40788

phil-davis opened this issue May 15, 2023 · 4 comments

Comments

@phil-davis
Copy link
Contributor

phil-davis commented May 15, 2023

Steps to reproduce

  1. Alice creates a folder "folder1" and puts file "test1.txt" in it.
  2. Alice shares the folder with Brian
  3. Brian creates a folder "myfolder" and puts file "mytest.txt" in it.
  4. Brian copies "myfolder" to "folder1"

Expected behaviour

Brian gets a 409 "conflict" response and the folder is not copied.

(alternative expected behavior could be some automatic-merge of the source folder tree into the target folder tree - but that is complicated)

Actual behaviour

Brian now has "folder1" with "mytest.txt" in it
The share from Alice to Brian is in the declined state
Alice has "folder1" with "test1.txt" in it

When Brian accepts the declined share from Alice, then Brian sees "folder1 (2)" with "test1.txt" in it.

Server configuration

Current oC10 core master

See PR #40308 for the test scenario(s)

@phil-davis
Copy link
Contributor Author

Note: if Alice does this with her own folders - copies folder1 "over the top of" folder2, then the previous content of folder2 is gone, and now contains copy of everything in folder1. There is no attempt at a "merge" of folder1 into folder2.

I don't know if that is the required behavior, or is just "what happens.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

Copy link

This issue has been automatically closed.

@phil-davis
Copy link
Contributor Author

I think that we want:

Expected behaviour
Brian gets a 409 "conflict" response and the folder is not copied.

and the test scenario was added in #40308

so this is still an open issue.

@phil-davis phil-davis reopened this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant