Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s deployment fails when there's no persistent volume claims to apply #1030

Open
snglth opened this issue Apr 2, 2024 · 4 comments · May be fixed by #1052
Open

K8s deployment fails when there's no persistent volume claims to apply #1030

snglth opened this issue Apr 2, 2024 · 4 comments · May be fixed by #1052
Labels
bug Bugs will be investigated and fixed as quickly as possible.

Comments

@snglth
Copy link

snglth commented Apr 2, 2024

Bug description

I have following options in my config.yml:

RUN_ELASTICSEARCH: false
RUN_MONGODB: false
RUN_MYSQL: false
RUN_REDIS: false
RUN_SMTP: false

It blocks k8s deployment since there's no persistent volume claims to apply:

-x tutor k8s start
kubectl get namespaces openedx
NAME      STATUS   AGE
openedx   Active   2d21h
Namespace already exists: skipping creation.
kubectl apply --kustomize /Users/snglth/Development/Abstract/fc-tutor/env --wait --selector app.kubernetes.io/component=volume
error: no objects passed to apply
Error: Command failed with status 1: kubectl apply --kustomize /Users/snglth/Development/Abstract/fc-tutor/env --wait --selector app.kubernetes.io/component=volume

I think that it should not be like that.

How to reproduce

Described above

Environment

macOS 14.4.1, tutor 17.0.3
Additional context
@regisb regisb added the bug Bugs will be investigated and fixed as quickly as possible. label Apr 2, 2024
@regisb regisb changed the title K8s deployment fails when there's no persistet volume claims to apply K8s deployment fails when there's no persistent volume claims to apply Apr 2, 2024
@snglth snglth linked a pull request Apr 29, 2024 that will close this issue
Open
@DawoudSheraz
Copy link
Contributor

Hi. Under what circumstances would we not want any volumes for k8s (by disabling all the configs)? In all the cases, are you relying on externally hosted services?

@yagouam
Copy link

yagouam commented May 10, 2024 •
edited

Hello @DawoudSheraz, that's exactly our use case. We have all the services externallized in another machine, out of our cluster.

@snglth
Copy link
Author

snglth commented May 10, 2024

This is also our case. We keep all the stateful services outsite of K8s cluster.

@angellareo
Copy link

Same case here. Fix works nicely. Thanks @snglth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bugs will be investigated and fixed as quickly as possible.
Projects
Tutor project management
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not fail on start when there are no persistent volume claims snglth/tutor
5 participants
@regisb @angellareo @snglth @DawoudSheraz @yagouam