Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade AWS SDK to v3 #5683

Closed
tommoor opened this issue Aug 12, 2023 · 3 comments · Fixed by #6731
Closed

Upgrade AWS SDK to v3 #5683

tommoor opened this issue Aug 12, 2023 · 3 comments · Fixed by #6731
Labels
chore Someone's gotta do it pinned Will not be closed by stale bot

Comments

@tommoor
Copy link
Member

tommoor commented Aug 12, 2023 

[backend] [api] (node:8956) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.
[backend] [api]
[backend] [api] Please migrate your code to use AWS SDK for JavaScript (v3).
[backend] [api] For more information, check the migration guide at https://a.co/7PzMCcy
@tommoor tommoor added the chore Someone's gotta do it label Aug 12, 2023
@adityabisht02
Copy link

I believe 2 things need to be done here,

  1. Removing the old aws-sdk v2 package and installing the v3 one
  2. Changing the imports in server -> storage -> files-> S3Storage.ts, which can be done with the aws-sdk codemod package (https://www.npmjs.com/package/aws-sdk-js-codemod).
  3. Changing the jest mock as well?

@tommoor
Copy link
Member Author

tommoor commented Aug 22, 2023

That sounds right, there might be a "gotcha" somewhere, perhaps a breaking change – I'm not sure.

@adityabisht02
Copy link

Yeah, I'll try working on this

@tommoor tommoor added the pinned Will not be closed by stale bot label Dec 2, 2023
@lng2020 lng2020 mentioned this issue Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Someone's gotta do it pinned Will not be closed by stale bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from s3 sdk v2 to v3 lng2020/outline
2 participants
@tommoor @adityabisht02