New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to sending JSON rather than Markdown to client #3000
Comments
@tommoor Do you have any ideas in mind for coming up with a JSON structure for transforming markdown? |
The format already exists, it's what the Markdown gets parsed into. It also exists inside the CRDT in the database which contains the collaborative state of any given document… eg.
|
fix: Attachments broken when using non-collab and AWS bucket on the same host (#3274)
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Work has begun on this, now that collaborative editing is the only editing option it makes things easier. Some features that this potentially unlocks:
|
🙏🏽 |
Problem
Currently when you request documents from the server we send a Markdown representation to the client which is rendered immediately. For collaborative editing we also render this while waiting for the collaborative connection to start to make the document appear faster.
This worked well up until now as every type of node could be serialized to Markdown in a reversible fashion – going forward this restriction should be removed so we can have items in the doc that cannot be represented in Markdown. For example fancy new node types, file attachments, comments etc.
Solution
Markdown will be used as an import/export type and markdown shortcuts will continue to work in the editor as today, however it will not be used to render in the app and may not be sent from the server at all unless requested explicitly for a download.
To migrate we'll need to convert all the existing docs in the database and store the JSON representation alongside the markdown.
The text was updated successfully, but these errors were encountered: