Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✔️ Add some additional test case + ✏️ Complete docs #51

Merged
merged 5 commits into from Jul 14, 2021

Conversation

Ousret
Copy link
Owner

@Ousret Ousret commented Jul 12, 2021

Originally I thought there was a problem in rendering large str (when encoding had SIG in it). But there was none.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #51 (044eed3) into master (bbff906) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files          11       11           
  Lines        1058     1058           
=======================================
  Hits          895      895           
  Misses        163      163           
Impacted Files Coverage Δ
charset_normalizer/api.py 83.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbff906...044eed3. Read the comment docs.

@Ousret Ousret marked this pull request as draft July 13, 2021 06:10
@Ousret Ousret changed the title Always strip the SIG in raw bytes except on u16/u32 🐛 Large payload decoded may leave the SIG in resulting str Jul 14, 2021
@Ousret Ousret changed the title 🐛 Large payload decoded may leave the SIG in resulting str ✔️ Add some additional test case Jul 14, 2021
@Ousret Ousret changed the title ✔️ Add some additional test case ✔️ Add some additional test case + ✏️ Complete docs Jul 14, 2021
@Ousret Ousret marked this pull request as ready for review July 14, 2021 20:23
@Ousret Ousret merged commit 171dfce into master Jul 14, 2021
@Ousret Ousret deleted the patch-strip-sig branch July 14, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants