Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove support for Python 3.5 #192

Merged
merged 4 commits into from Jun 18, 2022
Merged

🔥 Remove support for Python 3.5 #192

merged 4 commits into from Jun 18, 2022

Conversation

Ousret
Copy link
Owner

@Ousret Ousret commented Jun 18, 2022

Initial PR about the removal of Python 3.5
Some cleanup are required.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2022

Codecov Report

Merging #192 (dec171a) into master (4846792) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   89.86%   89.85%   -0.02%     
==========================================
  Files          11       11              
  Lines        1214     1212       -2     
==========================================
- Hits         1091     1089       -2     
  Misses        123      123              
Impacted Files Coverage Δ
charset_normalizer/api.py 86.76% <100.00%> (-0.07%) ⬇️
charset_normalizer/assets/__init__.py 100.00% <100.00%> (ø)
charset_normalizer/cd.py 96.34% <100.00%> (ø)
charset_normalizer/constant.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4846792...dec171a. Read the comment docs.

@Ousret Ousret merged commit 6ac98eb into master Jun 18, 2022
@Ousret Ousret deleted the drop-python35 branch June 18, 2022 16:24
@ofek
Copy link

ofek commented Jul 24, 2022

Python 3.6 is also EOL; will we drop that soon?

@Ousret
Copy link
Owner Author

Ousret commented Jul 24, 2022

I do not know for sure at the moment.
To be considered; some of our primary integrators like aiohttp still support it. And as far as I am aware, there is nothing in the code of this tiny library dedicated to python 3.6.
If we drop it, it would be as simple as patching the version requirement.

I am more inclined to keep the support while it does not create specific code or patchwork to make it work.
The probable outcome of this would be seen in the next major.

Hope that answers the question.

@ofek
Copy link

ofek commented Jul 24, 2022

Got it, thanks! When you do I'd like to open a PR switching to PEP 621 project metadata 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants