Re-use decoded buffer for short texts #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids issues with detecting string boundaries while improving performance (avoids multiple decoding of the sequence). Fixes Ousret#174
Ousret
requested changes
Mar 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 89.79% 89.86% +0.07%
==========================================
Files 11 11
Lines 1205 1214 +9
==========================================
+ Hits 1082 1091 +9
Misses 123 123
Continue to review full report at Codecov.
|
not meant to be publicly exposed
plus disable re-use on mb strings
bug discovered in Python, Zero Width No-Break Space located in Arabic Presentation Forms-B, Unicode 1.1 not acknowledged as space.
|
This PR does improve the overall quality and performance of the project and fixed an unexpected issue (in cpython). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids issues with detecting string boundaries while improving
performance (avoids multiple decoding of the sequence).
Fixes #174