Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Skipping CD on ASCII #155

Merged
merged 4 commits into from Dec 23, 2021
Merged

🔧 Skipping CD on ASCII #155

merged 4 commits into from Dec 23, 2021

Conversation

Ousret
Copy link
Owner

@Ousret Ousret commented Dec 23, 2021

The language detection (CD) on ASCII is often useless. With this PR we skip it and globally improve performance.

@Ousret Ousret added enhancement New feature or request detection Related to the charset detection mechanism, chaos/mess/coherence labels Dec 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #155 (ef0c0c3) into master (0fe3d54) will increase coverage by 0.00%.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   89.44%   89.45%           
=======================================
  Files          11       11           
  Lines        1194     1195    +1     
=======================================
+ Hits         1068     1069    +1     
  Misses        126      126           
Impacted Files Coverage Δ
charset_normalizer/api.py 87.21% <81.81%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe3d54...ef0c0c3. Read the comment docs.

@Ousret Ousret merged commit 5391e44 into master Dec 23, 2021
@Ousret Ousret deleted the patch-ascii-drop-cd branch December 23, 2021 07:52
@Ousret Ousret mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detection Related to the charset detection mechanism, chaos/mess/coherence enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants