Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong logging level applied when setting kwarg explain to True #146

Merged
merged 5 commits into from Nov 25, 2021

Conversation

Ousret
Copy link
Owner

@Ousret Ousret commented Nov 25, 2021

Following PR #135 , accidentally introduced a small regression.

@Ousret Ousret added the bug Something isn't working label Nov 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #146 (1561586) into master (e97718b) will decrease coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   89.62%   89.51%   -0.12%     
==========================================
  Files          11       11              
  Lines        1186     1192       +6     
==========================================
+ Hits         1063     1067       +4     
- Misses        123      125       +2     
Impacted Files Coverage Δ
charset_normalizer/api.py 87.50% <66.66%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97718b...1561586. Read the comment docs.

@Ousret Ousret merged commit 4e1c47a into master Nov 25, 2021
@Ousret Ousret deleted the fix-explain-level branch November 25, 2021 19:54
@Ousret Ousret mentioned this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants