Code style as refactored by Sourcery #131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Ousret, as I was looking for other things that could be made more efficient in the code I tried Sourcery on it.
The reasons why the code was changed are listed in the conversation here: https://github.com/adbar/charset_normalizer/pull/1
I just corrected the mypy type hints, otherwise I left it untouched. I have recently made good experiences with this kind of refactoring.
I particularly like the
sum()
operators introduced, the simplifiedif
clauses, theyield from
and the optimizedrange()
. Concerning theany()
I'm not sure if I prefer that style or the original.Anyway, please have a look and make any changes you like, it's just machine work ;)