Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❇️ Improvement over Vietnamese detection #126

Merged
merged 2 commits into from Oct 23, 2021

Conversation

Ousret
Copy link
Owner

@Ousret Ousret commented Oct 23, 2021

Latin characters with combining diacritical marks were miss detected/seen as mess (MD).

This file caught my attention.

Latin character with combining diacritical mark were miss detected/seen as mess (MD).
@Ousret Ousret added enhancement New feature or request detection Related to the charset detection mechanism, chaos/mess/coherence labels Oct 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2021

Codecov Report

Merging #126 (1984d31) into master (8b52c35) will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   90.25%   90.19%   -0.07%     
==========================================
  Files          11       11              
  Lines        1160     1163       +3     
==========================================
+ Hits         1047     1049       +2     
- Misses        113      114       +1     
Impacted Files Coverage Δ
charset_normalizer/md.py 96.29% <66.66%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b52c35...1984d31. Read the comment docs.

@Ousret
Copy link
Owner Author

Ousret commented Oct 23, 2021

Linked to #121

@Ousret Ousret merged commit 5c72742 into master Oct 23, 2021
@Ousret Ousret deleted the patch-vietnamese-improvement branch October 23, 2021 20:15
@Ousret Ousret mentioned this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detection Related to the charset detection mechanism, chaos/mess/coherence enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants