Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a schema for attachments #3

Open
leonard84 opened this issue Sep 28, 2022 · 2 comments
Open

Add a schema for attachments #3

leonard84 opened this issue Sep 28, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@leonard84
Copy link

Motivation

I think the use-case to have arbitrary attachments should be universal enough to merit inclusion in OTR directly, instead of every implementer creating a custom solution for this problem.

Implementation suggestion:

We could either have a generic attachment element that has html-attributes like src=URL, type=[image,video,file],
or we could have dedicated elements image[Attachment], video[Attachment], ...

The CLI tool should probably support moving local attachments to a new folder structure.

@marcphilipp
Copy link
Member

I'm in favor of a generic attachment which can either point to an external location via a URL or (for small files) its content can be included directly inside the report in base64-encoded form.

@marcphilipp marcphilipp reopened this Oct 1, 2022
@sormuras sormuras added the enhancement New feature or request label Oct 1, 2022
@marcphilipp
Copy link
Member

WIP PR: junit-team/junit5#3336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants