Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly exclude "off" rules in jsonc/auto #188

Merged
merged 1 commit into from Aug 16, 2022
Merged

Properly exclude "off" rules in jsonc/auto #188

merged 1 commit into from Aug 16, 2022

Conversation

clemyan
Copy link
Contributor

@clemyan clemyan commented Aug 16, 2022 •
edited

jsonc/auto did not properly detect if a core rule is turned off

{
    "rules": {
        "indent": "off", // ok
        "indent": 0, // not detected
        "indent": ["off", 4], // not detected
        "indent": [0, 4] // not detected
    }
}

This PR fixes this

ota-meshi
ota-meshi approved these changes Aug 16, 2022
View reviewed changes
Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 6dd88e4 into ota-meshi:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clemyan @ota-meshi