Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--previous-build-manifest with different layer num causes panic #624

Open
antheas opened this issue May 10, 2024 · 0 comments
Open

--previous-build-manifest with different layer num causes panic #624

antheas opened this issue May 10, 2024 · 0 comments
Labels
bug Something isn't working triaged

Comments

@antheas
Copy link

antheas commented May 10, 2024

If the user provides a --previous-build-manifest to rpm-ostree compose container-encapsulate which has a different number of max-layers than what was requested, the following line panics:

assert!(modified_build.len() <= bin_size.get() as usize);

Expected behavior would be to attempt to do the merge gracefully as far as this library is concerned. Failing that, rpm-ostree should emit a warning and ignore the previous manifest.

Context: I did a build that went from 100 layers to 50.

@cgwalters cgwalters added bug Something isn't working triaged labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged
Projects
None yet
Development

No branches or pull requests

2 participants