Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: Fix importing to archive repos #495

Open
cgwalters opened this issue Jun 20, 2023 · 3 comments
Open

container: Fix importing to archive repos #495

cgwalters opened this issue Jun 20, 2023 · 3 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers triaged

Comments

@cgwalters
Copy link
Member

Right now this fails due to https://github.com/ostreedev/ostree/blob/a113b2be3f597c2e4368f840063da70389e26fb0/src/libostree/ostree-repo-commit.c#L2745

Perhaps the simplest hack is to spawn a helper thread which writes the tar stream to a pipe, and then point a GUnixInputStream at the read side of the pipe

@cgwalters cgwalters added bug Something isn't working enhancement New feature or request good first issue Good for newcomers triaged labels Aug 25, 2023
@dbnicholson
Copy link
Member

I'd love if the root problem of pulling into an archive repo was fixed since I've run into that limitation in the past. Not a huge deal, though.

@cgwalters
Copy link
Member Author

@dbnicholson This only applies to containers, are you using that now?

@dbnicholson
Copy link
Member

@dbnicholson This only applies to containers, are you using that now?

Ah, no I'm not. There's some other feature that's not supported with archive mode repos, but I can't recall what it is. Carry on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers triaged
Projects
None yet
Development

No branches or pull requests

2 participants