Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

best effort GC #407

Open
cgwalters opened this issue Nov 11, 2022 · 0 comments
Open

best effort GC #407

cgwalters opened this issue Nov 11, 2022 · 0 comments

Comments

@cgwalters
Copy link
Member

See #404 (comment)

I think probably what we should do is change the GC invocation we make as part of the upgrader to be "best effort, log but don't propagate errors". But I think we also should at least in the unit tests actually make GC errors there fatal to ensure we catch bugs reliably.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cgwalters