Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tar: validate imported object set #1

Open
cgwalters opened this issue Apr 2, 2021 · 0 comments
Open

tar: validate imported object set #1

cgwalters opened this issue Apr 2, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@cgwalters
Copy link
Member

Due to the way ostree HTTP pulls work, we only fetch objects referenced transitively from a commit.

But when importing from a tarball, it's much more of a "push" model. A malicious blob could inject objects not referenced by the commit.

We should keep track of the set of objects starting from the first commit object (after validating it) and fatally error if we find something not in that set.

@cgwalters cgwalters transferred this issue from cgwalters/ostree-container Apr 4, 2021
@cgwalters cgwalters changed the title validate imported object set tar: validate imported object set Nov 3, 2021
@cgwalters cgwalters added the enhancement New feature or request label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant