You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ErrInvalidReason=errors.New("reason is not valid")
)
Clarify the desired types for annotations. Define if Paths should be under a Reason or under an Annotation and same thing for Probes. We need to understand the better way for users to fill in the annotations ( ⚠️ Add initial Maintainers Annotation parsing #3905 (comment)).
Define if in the case a check is annotated it should not be removed from SARIF result runs. Or, if is working as expected and we should not populate runs if there are no relevant results for that check ( ⚠️ Add initial Maintainers Annotation parsing #3905 (comment)).
Do we need to pass in checks here? Also this doesn't work if you only run a subset of checks but there's an annotation for a check which isn't being run.
Describe the bug
Some things still need to be addressed in Maintainers Annotation feature (regarding PR #3905):
scorecard/config/config.go
Lines 28 to 31 in 19f8ae1
runs
. Or, if is working as expected and we should not populateruns
if there are no relevantresults
for that check ( ⚠️ Add initial Maintainers Annotation parsing #3905 (comment)).scorecard/config/config.go
Lines 73 to 74 in 19f8ae1
scorecard/config/config_test.go
Lines 134 to 138 in 19f8ae1
scorecard/pkg/json.go
Lines 131 to 134 in 19f8ae1
.scorecard.yml
,.github/.scorecard.yml
, ...)The text was updated successfully, but these errors were encountered: