馃悰 Remove 32bit platforms from GoReleaser architectures #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
requested review from
azeemshaikh38,
justaugustus,
naveensrinivasan and
spencerschrock
as code owners
laurentsimon
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2541 +/- ##
=======================================
Coverage 39.95% 39.95%
=======================================
Files 122 122
Lines 9815 9815
=======================================
Hits 3922 3922
Misses 5612 5612
Partials 281 281 |
spencerschrock
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Do we have any metrics about how much 32bit gets used? I assume this is broken for anyone building from source after #2509?
It would be good to get this back later if possible
|
Integration tests success for |
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: laurentsimon laurentsimon@google.com
OSV-Scanner depends on a library that cannot be built for 32bit platforms, so this PR removes them from released binaries.