馃悰 Fix a bug in cron API data exporting #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azeemshaikh38
requested review from
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2112 +/- ##
==========================================
+ Coverage 42.43% 44.91% +2.48%
==========================================
Files 93 93
Lines 7596 7596
==========================================
+ Hits 3223 3412 +189
+ Misses 4123 3927 -196
- Partials 250 257 +7 |
azeemshaikh38
force-pushed
the
azeems/cron
branch
from
0e6736c
to
28db620
Compare
|
Integration tests success for |
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The current cron job writes its data to the releasetest bucket and also uses the wrong filename. This PR fixes that and fixes the naming convention used.
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
#1056
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)