Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Scorecard runs fail with any unrecognized steps #2103

Merged
merged 1 commit into from Jul 27, 2022

Conversation

azeemshaikh38
Copy link
Contributor

What kind of change does this PR introduce?

Scorecard action fails if the steps included as part of the Scorecard action job diverge from the "accepted" actions. Need to remove the extra step to conform to this.

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) July 27, 2022 22:15
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test July 27, 2022 22:15 Inactive
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #2103 (6fc54f5) into main (d7cb711) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2103   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files          93       93           
  Lines        7595     7595           
=======================================
  Hits         3205     3205           
  Misses       4141     4141           
  Partials      249      249           

Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@laurentsimon
Copy link
Contributor

Verification is working!

@github-actions
Copy link

Integration tests success for
[6fc54f5]
(https://github.com/ossf/scorecard/actions/runs/2749981551)

@azeemshaikh38 azeemshaikh38 merged commit 5fa7596 into main Jul 27, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/badge branch July 27, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants