馃悰 Bug fixing: recurring results of the scorecard fuzzing check for go built-in fuzzers #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidenwang9867
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
|
@laurentsimon @oliverchang PTAL at the bug fix for issue #2098 |
Codecov Report
@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
+ Coverage 42.19% 42.43% +0.23%
==========================================
Files 93 93
Lines 7595 7596 +1
==========================================
+ Hits 3205 3223 +18
+ Misses 4141 4123 -18
- Partials 249 250 +1 |
|
Integration tests success for |
|
Integration tests success for |
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A bug fix: issue #2098
What is the current behavior?
Under some specific circumstances, the scorecard fuzzing check returns extra recurring fuzzer results for Go built-in fuzzers. See issues #2060 and #2098.
What is the new behavior (if this is a feature change)?**
I am using a hashmap to drop potential duplicated prominent languages (theoretically there won't be any), so it is expected the fuzzing results will be correctly reported without any recurring contents.
Which issue(s) this PR fixes
Fixes #2098
Special notes for your reviewer
Does this PR introduce a user-facing change?
No.