✨ Feature: Dependency-diff API optimize: var re-naming, removing unused JSON tags #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidenwang9867
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2090 +/- ##
==========================================
+ Coverage 42.16% 44.62% +2.46%
==========================================
Files 92 92
Lines 7563 7569 +6
==========================================
+ Hits 3189 3378 +189
+ Misses 4126 3936 -190
- Partials 248 255 +7 |
…67/scorecard into depdiff_api_optimize
|
Integration tests success for |
|
Integration tests success for |
singhsaurabh
pushed a commit
to singhsaurabh/scorecard
that referenced
this pull request
Jul 25, 2022
…ed JSON tags (ossf#2090) * save * save * Update dependencydiff_result.go * save * save * save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
GetDependencydiffResultsAPI (PR ✨ Feature DependencyDiff (Version 0 Part 2) #2046) input param optimization (renaming ambiguous ones).Remove unnecessary struct JSON tags for
DependencyCheckResult: will define aJSONDependencyCheckResultstruct with JSON tags in PR ✨ Feature [experimental]: The Scorecard Dependencydiff CLI (Version 0 Part 1) #2077.What is the current behavior?
Var names such as
baseSHAandheadSHAmight be confusing and ambiguous since users can use either SHAs or branch names as the inputs; changing them tobaseandhead. There are some other minor changes on var names.Struct JSON tags for
DependencyCheckResultare unnecessary since we will define aJSONDependencyCheckResultstruct with JSON tags in PR #2077 to output JSON. (removing these tags)What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)