Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Export Scorecards results for API #2081

Merged
merged 3 commits into from Jul 23, 2022
Merged

✨ Export Scorecards results for API #2081

merged 3 commits into from Jul 23, 2022

Conversation

naveensrinivasan
Copy link
Member

  • Exporting the Scorecard results for the scorecard API.
  • The code exports as result.json without the commit SHA and also with
    the commit SHA.

Fixes #1056

@naveensrinivasan naveensrinivasan changed the title 🌱 Export Scorecards results for API ✨ Export Scorecards results for API Jul 20, 2022
laurentsimon
laurentsimon approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will let @azeemsgoogle confirm since he's more familiar with the code.

@naveensrinivasan
Copy link
Member Author

LGTM. Will let @azeemsgoogle confirm since he's more familiar with the code.

Thanks!

azeemshaikh38
azeemshaikh38 requested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to override the value of the GCS bucket in https://github.com/ossf/scorecard/blob/main/cron/k8s/worker.release.yaml so that the release cron job doesn't write to prod.

cron/internal/config/config.go Outdated Show resolved Hide resolved
cron/internal/config/config_test.go Outdated Show resolved Hide resolved
cron/internal/worker/main.go Outdated Show resolved Hide resolved
cron/internal/worker/main.go Show resolved Hide resolved
@naveensrinivasan
Copy link
Member Author

You'll also need to override the value of the GCS bucket in https://github.com/ossf/scorecard/blob/main/cron/k8s/worker.release.yaml so that the release cron job doesn't write to prod.

I have also updated the yaml. Thanks

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test July 21, 2022 17:03 Inactive
@codecov
Copy link

codecov bot commented Jul 21, 2022 •
edited

Codecov Report

Merging #2081 (37896fa) into main (30e3f64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2081   +/-   ##
=======================================
  Coverage   42.13%   42.13%           
=======================================
  Files          92       92           
  Lines        7569     7569           
=======================================
  Hits         3189     3189           
  Misses       4132     4132           
  Partials      248      248

@github-actions
Copy link

Integration tests success for
[28e68ff]
(https://github.com/ossf/scorecard/actions/runs/2713383161)

@github-actions
Copy link

Integration tests success for
[aa429d5]
(https://github.com/ossf/scorecard/actions/runs/2713390779)

@naveensrinivasan naveensrinivasan enabled auto-merge (squash) July 21, 2022 21:42
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test July 22, 2022 22:04 Inactive
@github-actions
Copy link

Integration tests success for
[c94f579]
(https://github.com/ossf/scorecard/actions/runs/2721413774)

azeemshaikh38
azeemshaikh38 approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments, please resolve before merging

cron/internal/config/config.go Outdated Show resolved Hide resolved
cron/k8s/worker.release.yaml Outdated Show resolved Hide resolved
azeemshaikh38
azeemshaikh38 approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @naveensrinivasan. Excited to see this in action!

@naveensrinivasan
🌱 Export Scorecards results for API
a539d93 
- Exporting the Scorecard results for the scorecard API.
- The code exports as result.json without the commit SHA and also with
  the commit SHA.
@naveensrinivasan
Some cleanup and tweaks.
7c4f002
@naveensrinivasan
Some cleanup and tweaks.
37896fa
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test July 23, 2022 02:05 Inactive
@naveensrinivasan naveensrinivasan enabled auto-merge (squash) July 23, 2022 02:05
@naveensrinivasan
Copy link
Member Author

Thanks a lot @naveensrinivasan. Excited to see this in action!

Thank you! I am also excited to have this feature!

@github-actions
Copy link

Integration tests success for
[37896fa]
(https://github.com/ossf/scorecard/actions/runs/2722112970)

@naveensrinivasan naveensrinivasan merged commit e23ee84 into main Jul 23, 2022
@naveensrinivasan naveensrinivasan deleted the naveen/feat/scorecardsapi branch July 23, 2022 02:37
@github-actions
Copy link

Integration tests success for
[f41b382]
(https://github.com/ossf/scorecard/actions/runs/2722112581)

singhsaurabh pushed a commit to singhsaurabh/scorecard that referenced this pull request Jul 25, 2022
@naveensrinivasan @singhsaurabh
✨ Export Scorecards results for API (ossf#2081)
c79e92a 
* 🌱 Export Scorecards results for API

- Exporting the Scorecard results for the scorecard API.
- The code exports as result.json without the commit SHA and also with
  the commit SHA.

* Some cleanup and tweaks.

* Some cleanup and tweaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeemshaikh38 azeemshaikh38 azeemshaikh38 approved these changes

@laurentsimon laurentsimon laurentsimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature - Web API for Scorecard bigquery data
3 participants
@naveensrinivasan @azeemshaikh38 @laurentsimon