🌱 Adjust 'exhaustive' linter to consider 'default' as exhaustive #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
spencerschrock
force-pushed
the
exhaustive-linter-default
branch
from
75c7636
to
3019db4
Compare
Codecov Report
@@ Coverage Diff @@
## main #2044 +/- ##
==========================================
+ Coverage 50.56% 53.19% +2.62%
==========================================
Files 87 87
Lines 7202 7202
==========================================
+ Hits 3642 3831 +189
+ Misses 3315 3119 -196
- Partials 245 252 +7 |
|
Integration tests success for |
…itch statements on enum members
spencerschrock
force-pushed
the
exhaustive-linter-default
branch
from
71ff6ec
to
2fe485b
Compare
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Configuration change for
golangci-lint. With the current linter settings,defaultis useless and satisfying the linter involves adding empty cases that clutter the code more thandefault. I realize this is subjective, but the current setting is overly cautious.What is the current behavior?
Switch statements on enums currently require cases for all enum members.
What is the new behavior (if this is a feature change)?**
defaultwill satisfy the linter now.Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)