馃尡 Build/test fixes: Install protoc and protoc-gen-go #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `validate-projects` Makefile target depends on compilation of all go binaries, including the protobuf generated go binaries
* Add an explicit dependency to the build-proto steps * Remove sleep
raghavkaul
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
laurentsimon
approved these changes
Jul 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #2038 +/- ##
==========================================
+ Coverage 50.56% 53.19% +2.62%
==========================================
Files 87 87
Lines 7202 7202
==========================================
+ Hits 3642 3831 +189
+ Misses 3315 3119 -196
- Partials 245 252 +7 |
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Build and test changes only. This PR updates the
maketarget for building cron protobufs to requireprotoc-gen-goto be installed first.What is the current behavior?
GH actions for recent Pulls (see: https://github.com/ossf/scorecard/runs/7198422780) are failing because
protoc-gen-gois not installed. This is package is installed as part oftools/tools.gowhich is built bymake install. Not all Make targets that requireprotoc-gen-gorunmake installfirst, but this likely worked intermittently due to step caching and parallelization.Testing Plan
All checks succeeded in a fork PR action run: raghavkaul#4
Does this PR introduce a user-facing change?