Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Signing scorecard images using cosign #1970

Merged
merged 2 commits into from May 31, 2022
Merged

🌱 Signing scorecard images using cosign #1970

merged 2 commits into from May 31, 2022

Conversation

naveensrinivasan
Copy link
Member

  • --wip-- [skip ci]
  • 🌱 Signing scorecard images using cosign

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test May 29, 2022 00:00 Inactive
@naveensrinivasan naveensrinivasan changed the title naveen/feat/sign containers 🌱 Signing scorecard images using cosign May 29, 2022
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test May 29, 2022 00:03 Inactive
@codecov
Copy link

codecov bot commented May 29, 2022 •
edited

Codecov Report

Merging #1970 (129a578) into main (4a88dac) will increase coverage by 2.81%.
The diff coverage is n/a.

❗ Current head 129a578 differs from pull request most recent head b1224a4. Consider uploading reports for the commit b1224a4 to get more accurate results

@@            Coverage Diff             @@
##             main    #1970      +/-   ##
==========================================
+ Coverage   51.34%   54.15%   +2.81%     
==========================================
  Files          83       83              
  Lines        6725     6725              
==========================================
+ Hits         3453     3642     +189     
+ Misses       3040     2844     -196     
- Partials      232      239       +7

@naveensrinivasan naveensrinivasan force-pushed the naveen/feat/sign-containers branch 2 times, most recently from a106a51 to b765267 Compare May 29, 2022 00:06
@naveensrinivasan naveensrinivasan marked this pull request as draft May 29, 2022 00:09
@github-actions
Copy link

Integration tests success for
[855655a]
(https://github.com/ossf/scorecard/actions/runs/2402614921)

@github-actions
Copy link

Integration tests success for
[8f027f1]
(https://github.com/ossf/scorecard/actions/runs/2402621978)

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test May 29, 2022 00:28 Inactive
@github-actions
Copy link

Integration tests success for
[93da787]
(https://github.com/ossf/scorecard/actions/runs/2402625646)

@github-actions
Copy link

Integration tests success for
[a5e6288]
(https://github.com/ossf/scorecard/actions/runs/2402683858)

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test May 29, 2022 14:22 Inactive
@github-actions
Copy link

Integration tests success for
[c59709b]
(https://github.com/ossf/scorecard/actions/runs/2404579061)

@naveensrinivasan naveensrinivasan marked this pull request as ready for review May 30, 2022 03:25
@naveensrinivasan naveensrinivasan enabled auto-merge (squash) May 30, 2022 03:26
laurentsimon
laurentsimon approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the plan to move to ko? (I have a SLSA builder for ko)

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test May 31, 2022 16:06 Inactive
@naveensrinivasan
--wip-- [skip ci]
a4e6166
@naveensrinivasan
🌱 Signing scorecard images using cosign
b1224a4 
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test May 31, 2022 16:20 Inactive
@github-actions
Copy link

Integration tests success for
[129a578]
(https://github.com/ossf/scorecard/actions/runs/2416266326)

@github-actions
Copy link

Integration tests success for
[b1224a4]
(https://github.com/ossf/scorecard/actions/runs/2416336278)

@naveensrinivasan naveensrinivasan merged commit 0eeb0c2 into main May 31, 2022
@naveensrinivasan naveensrinivasan deleted the naveen/feat/sign-containers branch May 31, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@azeemshaikh38 azeemshaikh38 Awaiting requested review from azeemshaikh38

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@naveensrinivasan @laurentsimon