Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Replace clients.Contributor with clients.User #1957

Merged
merged 2 commits into from May 31, 2022

Conversation

azeemshaikh38
Copy link
Contributor

What kind of change does this PR introduce?

Fixes #1943.
(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #1943

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #1957 (6547cb2) into main (f712144) will increase coverage by 2.82%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
+ Coverage   51.34%   54.17%   +2.82%     
==========================================
  Files          83       83              
  Lines        6725     6723       -2     
==========================================
+ Hits         3453     3642     +189     
+ Misses       3040     2842     -198     
- Partials      232      239       +7     

@github-actions
Copy link

Integration tests success for
[04627d6]
(https://github.com/ossf/scorecard/actions/runs/2381505582)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test May 25, 2022 02:42 Inactive
@github-actions
Copy link

Integration tests success for
[aecf394]
(https://github.com/ossf/scorecard/actions/runs/2381797076)

@azeemshaikh38
Copy link
Contributor Author

Ping for review

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test May 31, 2022 19:51 Inactive
@github-actions
Copy link

Integration tests success for
[6547cb2]
(https://github.com/ossf/scorecard/actions/runs/2417367926)

@azeemshaikh38 azeemshaikh38 merged commit 1d9cd05 into main May 31, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/contributors branch May 31, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share common data structures between checker and client packages
3 participants