Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Do not fail on empty repositories #1914

Merged
merged 1 commit into from May 16, 2022
Merged

Conversation

azeemshaikh38
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix: Vuln check was failing for empty repositories.

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Part of #1901

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@github-actions
Copy link

Integration tests success for
[97d6a27]
(https://github.com/ossf/scorecard/actions/runs/2328594711)

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #1914 (a0ca819) into main (b1ab7eb) will increase coverage by 3.06%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main    #1914      +/-   ##
==========================================
+ Coverage   51.63%   54.70%   +3.06%     
==========================================
  Files          79       79              
  Lines        6774     6782       +8     
==========================================
+ Hits         3498     3710     +212     
+ Misses       3045     2835     -210     
- Partials      231      237       +6     

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) May 16, 2022 00:16
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test May 16, 2022 00:16 Inactive
@github-actions
Copy link

Integration tests success for
[a0ca819]
(https://github.com/ossf/scorecard/actions/runs/2328958726)

@azeemshaikh38 azeemshaikh38 merged commit 236b296 into main May 16, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/empty-repo branch May 16, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants