Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: tag builds as stable after the releasetest is successful #1901

Closed
laurentsimon opened this issue May 11, 2022 · 7 comments
Closed
Labels
kind/enhancement New feature or request

Comments

@laurentsimon
Copy link
Contributor

Is it feasible to tag builds/container images as stable after they have successfully run the releasetest integration tests?

@azeemsgoogle WDUT?

@laurentsimon laurentsimon added the kind/enhancement New feature or request label May 11, 2022
@azeemsgoogle
Copy link
Contributor

Yes, that's what we do today already. A successful run of releasetest automatically tags the associated container images as :stable. Did you mean this or something else?

@laurentsimon
Copy link
Contributor Author

ok, interesting. I pushed some commits on Monday and did not see that commit tagged as "stable". I need to double check then

@azeemshaikh38
Copy link
Contributor

You are right. Looks like the recent releastest did not successfully transfer to BQ for the past few days, hence did not get marked :stable. Looking at the logs seems like a secondary rate limit issue, specifically the "Search" API which has much lower rate limits.

@azeemshaikh38
Copy link
Contributor

So I think I figured out what's going on. After #1886 lot of repositories were failing for 2 reasons:

IMO, we should fix #1320 to fix the failing releasetests before making a new release. @naveensrinivasan @laurentsimon wdyt?

@laurentsimon
Copy link
Contributor Author

@asraa do you have cycles to fix #1320?

@azeemshaikh38
Copy link
Contributor

@asraa do you have cycles to fix #1320?

I believe @naveensrinivasan plan's to work on this issue?

@laurentsimon
Copy link
Contributor Author

Thanks @naveensrinivasan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants