馃悰 Fix bug in Scorecard tag Docker image creation #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azeemshaikh38
requested review from
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
laurentsimon
approved these changes
May 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #1890 +/- ##
=======================================
Coverage 51.27% 51.27%
=======================================
Files 80 80
Lines 6797 6797
=======================================
Hits 3485 3485
Misses 3081 3081
Partials 231 231 |
|
Integration tests success for |
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
There is a bug in how we generate Docker images for new tags (like v4.2.0). Currently we tag HEAD as the latest tag irrespective of which commit the tag it applied to. This PR fixes that.
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)