Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support commits reviewed through Piper #1889

Merged
merged 1 commit into from May 6, 2022
Merged

Conversation

azeemshaikh38
Copy link
Contributor

What kind of change does this PR introduce?

Support commits reviewed through Piper (Google code review tool). There are 8M+ commits on GitHub which pass this requirement - https://github.com/search?q=PiperOrigin-RevId&type=commits

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Support PRs reviewed using Piper

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test May 6, 2022 17:35 Inactive
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1889 (71404a4) into main (9a7d030) will increase coverage by 3.00%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##             main    #1889      +/-   ##
==========================================
+ Coverage   51.35%   54.36%   +3.00%     
==========================================
  Files          79       79              
  Lines        6729     6740      +11     
==========================================
+ Hits         3456     3664     +208     
+ Misses       3043     2839     -204     
- Partials      230      237       +7     

@github-actions
Copy link

github-actions bot commented May 6, 2022

Integration tests success for
[71404a4]
(https://github.com/ossf/scorecard/actions/runs/2283167050)

Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Interesting PR!

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) May 6, 2022 18:37
@azeemshaikh38 azeemshaikh38 merged commit 22694dc into main May 6, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/piper branch May 6, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants