✨ Add support for Phabricator as a code review system

[vihangm]

What kind of change does this PR introduce?

Supports the "Reviewed By" field used by Phabricator to check if a repo uses Phabricator as their code review system.

• PR title follows the guidelines defined in our pull request documentation

What is the current behavior?

Repos that use Phabricator are marked as not requiring code review.

What is the new behavior (if this is a feature change)?**

• Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #1883

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Repositories using Phabricator will now pass the Code review check.

[github-actions]

Integration tests success for
[1e2116b]
(https://github.com/ossf/scorecard/actions/runs/2267833904)

[codecov]

Codecov Report

Merging #1884 (aef4781) into main (f779fb8) will increase coverage by 2.93%.
The diff coverage is 44.00%.

@@            Coverage Diff             @@
##             main    #1884      +/-   ##
==========================================
+ Coverage   51.42%   54.36%   +2.93%     
==========================================
  Files          79       79              
  Lines        6709     6729      +20     
==========================================
+ Hits         3450     3658     +208     
+ Misses       3031     2834     -197     
- Partials      228      237       +9     

[azeemshaikh38]

Looks like we don't check for anything Gerrit or Phabricator specific in our code at all. Wonder, if we should generalize this to:

reviewPlatformCommitMsg = "ReviewedCommitMessage"

func hasCommitMsgReview() bool {
  regexpMatch, reviewedBy := regexp.Match("\nReviewed By: (\S+)")
  if regexpMatch {
    // Log reviewedBy
  }
  regexpMatch, reviewedOn := regexp.Match("\nReviewed On: (\S+)")
  if regexpMatch {
    // Log reviewedOn
  }
}

Note that above is mostly pseudo-code. @laurentsimon wdyt?

[laurentsimon]

Looks like we don't check for anything Gerrit or Phabricator specific in our code at all. Wonder, if we should generalize this to:

reviewPlatformCommitMsg = "ReviewedCommitMessage"

func hasCommitMsgReview() bool {
  regexpMatch, reviewedBy := regexp.Match("\nReviewed By: (\S+)")
  if regexpMatch {
    // Log reviewedBy
  }
  regexpMatch, reviewedOn := regexp.Match("\nReviewed On: (\S+)")
  if regexpMatch {
    // Log reviewedOn
  }
}

Note that above is mostly pseudo-code. @laurentsimon wdyt?

I don't mind improving it.

[vihangm]

Happy to generalize it.
I also realized that I could do some validation to check if the review system is actually Phabricator by looking for the Differential Revision: field.
LMK which one you prefer.

[laurentsimon]

Happy to generalize it. I also realized that I could do some validation to check if the review system is actually Phabricator by looking for the Differential Revision: field. LMK which one you prefer.

Looking for Differential Revision: would be great if it allows us to differentiate with Gerrit - I'm not super familiar with any of the reviewing system, to be completely honest.

[vihangm]

Happy to generalize it. I also realized that I could do some validation to check if the review system is actually Phabricator by looking for the Differential Revision: field. LMK which one you prefer.

Looking for Differential Revision: would be great if it allows us to differentiate with Gerrit - I'm not super familiar with any of the reviewing system, to be completely honest.

Yeah, let me actually add the additional check.

[github-actions]

Integration tests success for
[366844a]
(https://github.com/ossf/scorecard/actions/runs/2271150139)

[github-actions]

Integration tests success for
[ae51622]
(https://github.com/ossf/scorecard/actions/runs/2271422626)

[azeemshaikh38]

Thanks!

[github-actions]

Integration tests success for
[aef4781]
(https://github.com/ossf/scorecard/actions/runs/2277095696)