From 98dbc298f8ef58864d43ab6cd0365d07ed0cccf4 Mon Sep 17 00:00:00 2001 From: laurentsimon Date: Tue, 3 May 2022 16:18:46 +0000 Subject: [PATCH] e2e fix --- e2e/binary_artifacts_test.go | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/e2e/binary_artifacts_test.go b/e2e/binary_artifacts_test.go index 5a65805c5976..16ce35de7c93 100644 --- a/e2e/binary_artifacts_test.go +++ b/e2e/binary_artifacts_test.go @@ -85,10 +85,7 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() { NumberOfDebug: 0, } result := checks.BinaryArtifacts(&req) - // UPGRADEv2: to remove. - // Old version. - Expect(result.Pass).Should(BeFalse()) - // New version. + Expect(scut.ValidateTestReturn(nil, "binary artifacts", &expected, &result, &dl)).Should(BeTrue()) Expect(repoClient.Close()).Should(BeNil()) }) @@ -116,10 +113,7 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() { NumberOfDebug: 0, } result := checks.BinaryArtifacts(&req) - // UPGRADEv2: to remove. - // Old version. - Expect(result.Pass).Should(BeFalse()) - // New version. + Expect(scut.ValidateTestReturn(nil, "binary artifacts", &expected, &result, &dl)).Should(BeTrue()) Expect(repoClient.Close()).Should(BeNil()) }) @@ -165,11 +159,12 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() { Repo: repo, Dlogger: &dl, } - // TODO: upload real binaries to the repo as well. + // TODO: upload real binaries to the repo. + // Existing binaries only contain SCII characters and are ignored. expected := scut.TestReturn{ Error: nil, - Score: checker.MaxResultScore - 4, - NumberOfWarn: 4, + Score: checker.MaxResultScore, + NumberOfWarn: 0, NumberOfInfo: 0, NumberOfDebug: 0, } @@ -203,11 +198,12 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() { Repo: repo, Dlogger: &dl, } - // TODO: upload real binaries to the repo as well. + // TODO: upload real binaries to the repo. + // Existing binaries only contain SCII characters and are ignored. expected := scut.TestReturn{ Error: nil, - Score: checker.MaxResultScore - 4, - NumberOfWarn: 4, + Score: checker.MaxResultScore, + NumberOfWarn: 0, NumberOfInfo: 0, NumberOfDebug: 0, }