Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Prepare for v2 beta1 release #766

Merged
merged 4 commits into from Jul 21, 2022
Merged

🌱 Prepare for v2 beta1 release #766

merged 4 commits into from Jul 21, 2022

Conversation

azeemshaikh38
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 commented Jul 15, 2022

Commit created from this PR will be used to generate the pre-release of scorecard-action. I've decided to name the tag - v2.0.0-beta.1.

action.yaml Outdated Show resolved Hide resolved
@justaugustus justaugustus added this to In progress in Scorecard via automation Jul 15, 2022
@justaugustus
Copy link
Member

(Let's also see if we can drain the remaining dependabot updates before cutting the release)

Co-authored-by: Stephen Augustus (he/him) <justaugustus@users.noreply.github.com>
@azeemshaikh38
Copy link
Contributor Author

(Let's also see if we can drain the remaining dependabot updates before cutting the release)

Fair point. Looking into it.

@azeemshaikh38
Copy link
Contributor Author

(Let's also see if we can drain the remaining dependabot updates before cutting the release)

Fair point. Looking into it.

Getting errors running go mod tidy:

go mod tidy
go: finding module for package go.opentelemetry.io/otel/metric/registry
go: finding module for package go.opentelemetry.io/otel/semconv
github.com/ossf/scorecard-action/signing imports
        github.com/sigstore/cosign/cmd/cosign/cli/sign imports
        github.com/sigstore/cosign/cmd/cosign/cli/fulcio/fulcioverifier/ctl imports
        github.com/google/certificate-transparency-go imports
        go.etcd.io/etcd/v3 imports
        go.etcd.io/etcd/tests/v3/integration imports
        go.etcd.io/etcd/server/v3/embed imports
        go.opentelemetry.io/otel/semconv: module go.opentelemetry.io/otel@latest found (v1.8.0), but does not contain package go.opentelemetry.io/otel/semconv
github.com/ossf/scorecard-action/signing imports
        github.com/sigstore/cosign/cmd/cosign/cli/sign imports
        github.com/sigstore/cosign/cmd/cosign/cli/fulcio/fulcioverifier/ctl imports
        github.com/google/certificate-transparency-go imports
        go.etcd.io/etcd/v3 imports
        go.etcd.io/etcd/tests/v3/integration imports
        go.etcd.io/etcd/server/v3/embed imports
        go.opentelemetry.io/otel/exporters/otlp imports
        go.opentelemetry.io/otel/sdk/metric/controller/basic imports
        go.opentelemetry.io/otel/metric/registry: module go.opentelemetry.io/otel/metric@latest found (v0.31.0), but does not contain package go.opentelemetry.io/otel/metric/registry

Anyone have an idea?

RELEASE.md Outdated Show resolved Hide resolved
action.yaml Show resolved Hide resolved
@naveensrinivasan
Copy link
Member

(Let's also see if we can drain the remaining dependabot updates before cutting the release)

Fair point. Looking into it.

Getting errors running go mod tidy:

go mod tidy
go: finding module for package go.opentelemetry.io/otel/metric/registry
go: finding module for package go.opentelemetry.io/otel/semconv
github.com/ossf/scorecard-action/signing imports
        github.com/sigstore/cosign/cmd/cosign/cli/sign imports
        github.com/sigstore/cosign/cmd/cosign/cli/fulcio/fulcioverifier/ctl imports
        github.com/google/certificate-transparency-go imports
        go.etcd.io/etcd/v3 imports
        go.etcd.io/etcd/tests/v3/integration imports
        go.etcd.io/etcd/server/v3/embed imports
        go.opentelemetry.io/otel/semconv: module go.opentelemetry.io/otel@latest found (v1.8.0), but does not contain package go.opentelemetry.io/otel/semconv
github.com/ossf/scorecard-action/signing imports
        github.com/sigstore/cosign/cmd/cosign/cli/sign imports
        github.com/sigstore/cosign/cmd/cosign/cli/fulcio/fulcioverifier/ctl imports
        github.com/google/certificate-transparency-go imports
        go.etcd.io/etcd/v3 imports
        go.etcd.io/etcd/tests/v3/integration imports
        go.etcd.io/etcd/server/v3/embed imports
        go.opentelemetry.io/otel/exporters/otlp imports
        go.opentelemetry.io/otel/sdk/metric/controller/basic imports
        go.opentelemetry.io/otel/metric/registry: module go.opentelemetry.io/otel/metric@latest found (v0.31.0), but does not contain package go.opentelemetry.io/otel/metric/registry

Anyone have an idea?

Is this on your branch?

@azeemshaikh38
Copy link
Contributor Author

Is this on your branch?

No, this is on HEAD.

@naveensrinivasan
Copy link
Member

Is this on your branch?

No, this is on HEAD.

Looks like this is the problem open-telemetry/opentelemetry-go#2938 (comment)

@azeemshaikh38
Copy link
Contributor Author

Is this on your branch?

No, this is on HEAD.

Looks like this is the problem open-telemetry/opentelemetry-go#2938 (comment)

Thanks, that's a great find! I'll try to see if I can use the comments there to resolve our dependency problem.

@naveensrinivasan
Copy link
Member

Is this on your branch?

No, this is on HEAD.

Looks like this is the problem open-telemetry/opentelemetry-go#2938 (comment)

Thanks, that's a great find! I'll try to see if I can use the comments there to resolve our dependency problem.

It is a replace directive as the project has broken the API, and the downstream hasn't changed. This is dependency hell.

@naveensrinivasan
Copy link
Member

(Let's also see if we can drain the remaining dependabot updates before cutting the release)

Fair point. Looking into it.

Most of them have been merged!

@azeemshaikh38
Copy link
Contributor Author

(Let's also see if we can drain the remaining dependabot updates before cutting the release)

@justaugustus blocked on your approval. Dependabot alerts are now fixed.

@justaugustus
Copy link
Member

@justaugustus blocked on your approval. Dependabot alerts are now fixed.

Azeem, can you investigate the unit test failures?
I believe it's related to the signing logic.

@azeemshaikh38
Copy link
Contributor Author

@justaugustus blocked on your approval. Dependabot alerts are now fixed.

Azeem, can you investigate the unit test failures? I believe it's related to the signing logic.

They are intermittent failures since the issue is with the REST API the test talks to (its a mock request, so the failures are only happening on the test but prod works fine). The fix is going to be on the API side, no changes needed here. Will retry the test to get it to pass.

@azeemshaikh38
Copy link
Contributor Author

@justaugustus blocked on your approval. Dependabot alerts are now fixed.

Azeem, can you investigate the unit test failures? I believe it's related to the signing logic.

Fixed now with the retry :)

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #766 (6189f6e) into main (ccd0038) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #766   +/-   ##
=======================================
  Coverage   63.63%   63.63%           
=======================================
  Files           4        4           
  Lines         231      231           
=======================================
  Hits          147      147           
  Misses         72       72           
  Partials       12       12           
Impacted Files Coverage Δ
signing/signing.go 32.14% <0.00%> (ø)

@azeemshaikh38
Copy link
Contributor Author

@justaugustus blocked on your approval. Dependabot alerts are now fixed.

Azeem, can you investigate the unit test failures? I believe it's related to the signing logic.

Fixed now with the retry :)

@justaugustus friendly ping.

Scorecard automation moved this from In progress to Reviewer approved Jul 21, 2022
@azeemshaikh38 azeemshaikh38 merged commit 3155d13 into main Jul 21, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/golang-bug branch July 21, 2022 17:10
Scorecard automation moved this from Reviewer approved to Done Jul 21, 2022
@justaugustus
Copy link
Member

@justaugustus friendly ping.

Thanks for the details on the failure.
Approved!

bors bot added a commit to OpenPoolProject/stratum that referenced this pull request Nov 6, 2022
273: chore(deps): update ossf/scorecard-action action to v2 r=renovate[bot] a=renovate[bot]

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ossf/scorecard-action](https://togithub.com/ossf/scorecard-action) | action | major | `v1.1.1` -> `v2.0.6` |

---

### Release Notes

<details>
<summary>ossf/scorecard-action</summary>

### [`v2.0.6`](https://togithub.com/ossf/scorecard-action/releases/tag/v2.0.6)

[Compare Source](https://togithub.com/ossf/scorecard-action/compare/v2.0.5...v2.0.6)

#### What's Changed

-   Fix - Broken dockerfile by [`@&#8203;naveensrinivasan](https://togithub.com/naveensrinivasan)` in [ossf/scorecard-action#979

**Full Changelog**: ossf/scorecard-action@v2.0.5...v2.0.6

### [`v2.0.5`](https://togithub.com/ossf/scorecard-action/releases/tag/v2.0.5)

[Compare Source](https://togithub.com/ossf/scorecard-action/compare/v2.0.4...v2.0.5)

#### What's Changed

-   Remove trailing space from example by [`@&#8203;jamacku](https://togithub.com/jamacku)` in [ossf/scorecard-action#955
-   🌱 Bump actions/cache from 3.0.8 to 3.0.10 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#956
-   🌱 Bump github/codeql-action from 2.1.25 to 2.1.26 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#957
-   🌱 Bump step-security/harden-runner from 1.4.5 to 1.5.0 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#958
-   🌱 Bump debian from `5cf1d98` to `b46fc4e` by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#959
-   🌱 Bump github.com/sigstore/cosign from 1.12.1 to 1.13.0 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#962
-   🌱 Upgrade to go 1.19 by [`@&#8203;naveensrinivasan](https://togithub.com/naveensrinivasan)` in [ossf/scorecard-action#961
-   🌱 Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#967
-   🌱 Bump golang from `c2a98a5` to `b850621` by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#966
-   🌱 Bump golang from `b850621` to `25de7b6` by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#968
-   New release for Scorecard v4.8.0 by [`@&#8203;naveensrinivasan](https://togithub.com/naveensrinivasan)` in [ossf/scorecard-action#969

#### New Contributors

-   [`@&#8203;jamacku](https://togithub.com/jamacku)` made their first contribution in [ossf/scorecard-action#955

**Full Changelog**: ossf/scorecard-action@v2.0.4...v2.0.5

### [`v2.0.4`](https://togithub.com/ossf/scorecard-action/releases/tag/v2.0.4)

[Compare Source](https://togithub.com/ossf/scorecard-action/compare/v2.0.3...v2.0.4)

Fixes [#&#8203;856](https://togithub.com/ossf/scorecard-action/issues/856)

#### What's Changed

-   🌱 Bump github.com/caarlos0/env/v6 from 6.10.0 to 6.10.1 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#934
-   feat: do not run signing on pull requests by [`@&#8203;laurentsimon](https://togithub.com/laurentsimon)` in [ossf/scorecard-action#935
-   🌱 Bump debian from 11.4-slim to 11.5-slim by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#936
-   🌱 Bump github.com/sigstore/cosign from 1.11.1 to 1.12.0 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#938
-   🌱 Bump github/codeql-action from 2.1.22 to 2.1.24 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#941
-   🐛 Restore behavior of ignoring scorecard runtime errors by [`@&#8203;spencerschrock](https://togithub.com/spencerschrock)` in [ossf/scorecard-action#948
-   🌱 Bump actions/dependency-review-action from 2.1.0 to 2.4.0 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#950
-   🌱 Bump github.com/sigstore/cosign from 1.12.0 to 1.12.1 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#947
-   🌱 Bump github/codeql-action from 2.1.24 to 2.1.25 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#949
-   🌱 Bump codecov/codecov-action from 3.1.0 to 3.1.1 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#942
-   Create v2.0.4 patch by [`@&#8203;spencerschrock](https://togithub.com/spencerschrock)` in [ossf/scorecard-action#952

#### New Contributors

-   [`@&#8203;spencerschrock](https://togithub.com/spencerschrock)` made their first contribution in [ossf/scorecard-action#948

**Full Changelog**: ossf/scorecard-action@v2.0.3...v2.0.4

### [`v2.0.3`](https://togithub.com/ossf/scorecard-action/releases/tag/v2.0.3)

[Compare Source](https://togithub.com/ossf/scorecard-action/compare/v2.0.2...v2.0.3)

Patch for fix in [#&#8203;898](https://togithub.com/ossf/scorecard-action/issues/898)

### [`v2.0.2`](https://togithub.com/ossf/scorecard-action/releases/tag/v2.0.2)

[Compare Source](https://togithub.com/ossf/scorecard-action/compare/v2.0.1...v2.0.2)

Fixes [ossf/scorecard-action#895

### [`v2.0.1`](https://togithub.com/ossf/scorecard-action/releases/tag/v2.0.1)

[Compare Source](https://togithub.com/ossf/scorecard-action/compare/v2.0.0...v2.0.1)

Fix for [#&#8203;856](https://togithub.com/ossf/scorecard-action/issues/856)

### [`v2.0.0`](https://togithub.com/ossf/scorecard-action/releases/tag/v2.0.0)

[Compare Source](https://togithub.com/ossf/scorecard-action/compare/v1.1.2...v2.0.0)

#### What's Changed

-   🌱 Prepare for a pre-release of the Golang action by [`@&#8203;azeemshaikh38](https://togithub.com/azeemshaikh38)` in [ossf/scorecard-action#750
-   🌱 Bump github/codeql-action from 2.1.12 to 2.1.16 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#751
-   🌱 Bump debian from 11.3-slim to 11.4-slim by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#749
-   🌱 Bump step-security/harden-runner from 1.4.3 to 1.4.4 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#646
-   🌱 Bump actions/setup-go from 3.2.0 to 3.2.1 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#748
-   🐛 Fix dependency conflicts in go.mod by [`@&#8203;azeemshaikh38](https://togithub.com/azeemshaikh38)` in [ossf/scorecard-action#771
-   🌱 Prepare for v2 beta1 release by [`@&#8203;azeemshaikh38](https://togithub.com/azeemshaikh38)` in [ossf/scorecard-action#766
-   multi-repo-action: Note that tool is a work-in-progress by [`@&#8203;naveensrinivasan](https://togithub.com/naveensrinivasan)` in [ossf/scorecard-action#776
-   🐛 Fix intermittent failures in CI-Tests by [`@&#8203;azeemshaikh38](https://togithub.com/azeemshaikh38)` in [ossf/scorecard-action#778
-   🌱 Bump sigs.k8s.io/release-utils from 0.7.2 to 0.7.3 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#775
-   🌱 Bump actions/cache from 3.0.4 to 3.0.5 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#769
-   📖 Update README about the restrictions for scorecard-action:v2 by [`@&#8203;azeemshaikh38](https://togithub.com/azeemshaikh38)` in [ossf/scorecard-action#779
-   🌱 Bump github/codeql-action from 2.1.16 to 2.1.17 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#783
-   📖 Update instructions for Scorecard badge to README by [`@&#8203;azeemshaikh38](https://togithub.com/azeemshaikh38)` in [ossf/scorecard-action#785
-   🌱 Bump debian from `f576b80` to `a811e62` by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#787
-   🌱 Bump github.com/ossf/scorecard/v4 from 4.4.0 to 4.5.0 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#786
-   🌱 Bump github/codeql-action from 2.1.17 to 2.1.18 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#788
-   🌱 Bump actions/cache from 3.0.5 to 3.0.6 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#789
-   🐛 Add request application/json request header by [`@&#8203;azeemshaikh38](https://togithub.com/azeemshaikh38)` in [ossf/scorecard-action#791
-   Create a new release v2.0.0-alpha.1 by [`@&#8203;azeemshaikh38](https://togithub.com/azeemshaikh38)` in [ossf/scorecard-action#803
-   🌱 Bump actions/cache from 3.0.6 to 3.0.7 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#807
-   Olivekl patch 1 by [`@&#8203;olivekl](https://togithub.com/olivekl)` in [ossf/scorecard-action#809
-   🌱 Fix cosign vulnerability by [`@&#8203;naveensrinivasan](https://togithub.com/naveensrinivasan)` in [ossf/scorecard-action#812
-   🌱 Allow for publish URL override by [`@&#8203;azeemshaikh38](https://togithub.com/azeemshaikh38)` in [ossf/scorecard-action#811
-   🌱 Bump github.com/ossf/scorecard/v4 from 4.5.0 to 4.6.0 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#820
-   🌱 Bump step-security/harden-runner from 1.4.4 to 1.4.5 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#808
-   cmd/installer: Cleanups (2/n) by [`@&#8203;justaugustus](https://togithub.com/justaugustus)` in [ossf/scorecard-action#833
-   Update comments to allow for renovatebot updates by [`@&#8203;laurentsimon](https://togithub.com/laurentsimon)` in [ossf/scorecard-action#834
-   🌱 Bump github.com/caarlos0/env/v6 from 6.9.3 to 6.10.0 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#839
-   🌱 Update actions/checkout requirement to [`2541b12`](https://togithub.com/ossf/scorecard-action/commit/2541b1294d2704b0964813337f33b291d3f8596b) by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#835
-   🌱 Bump github.com/sigstore/cosign from 1.11.0 to 1.11.1 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#842
-   🌱 Bump github/codeql-action from 2.1.18 to 2.1.21 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#844
-   🌱 Bump actions/setup-go from 3.2.1 to 3.3.0 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#843
-   🌱 Bump debian from `a811e62` to `68c1f6b` by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#840
-   Fix workflow path in automatic creation of PR  by [`@&#8203;RadoslavGatev](https://togithub.com/RadoslavGatev)` in [ossf/scorecard-action#845
-   🌱 Bump actions/dependency-review-action from [`310e0dd`](https://togithub.com/ossf/scorecard-action/commit/310e0dd64f63b1d00101ecd3225d605a74261fb7) to 2.1.0 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#838
-   🌱 Bump actions/cache from 3.0.7 to 3.0.8 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#836
-   📖 Add docs for API by [`@&#8203;azeemshaikh38](https://togithub.com/azeemshaikh38)` in [ossf/scorecard-action#849
-   🌱 Bump github/codeql-action from 2.1.21 to 2.1.22 by [`@&#8203;dependabot](https://togithub.com/dependabot)` in [ossf/scorecard-action#853
-   🌱 Included License by [`@&#8203;naveensrinivasan](https://togithub.com/naveensrinivasan)` in [ossf/scorecard-action#852
-   🌱 Release v2.0.0 by [`@&#8203;naveensrinivasan](https://togithub.com/naveensrinivasan)` in [ossf/scorecard-action#854

#### New Contributors

-   [`@&#8203;RadoslavGatev](https://togithub.com/RadoslavGatev)` made their first contribution in [ossf/scorecard-action#845

**Full Changelog**: ossf/scorecard-action@v1.1.2...v2.0.0

### [`v1.1.2`](https://togithub.com/ossf/scorecard-action/releases/tag/v1.1.2)

[Compare Source](https://togithub.com/ossf/scorecard-action/compare/v1.1.1...v1.1.2)

#### What's Changed

-   Fix for [ossf/scorecard-action#329

**Full Changelog**: ossf/scorecard-action@v1.1.1...v1.1.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/OpenPoolProject/stratum).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzQuMTkuMCJ9-->


Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants