Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add warning for empty repo token #71

Merged
merged 1 commit into from Feb 1, 2022

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Jan 27, 2022

entrypoint.sh: add warning if token is empty

Add warning to let users know how to fix an empty PAT token.
Add additional warning if the repo is a fork.

closes #70

@laurentsimon
Copy link
Contributor Author

@nibanks can you try with uses: laurentsimon/scorecard-action@bug/emptypat and confirm it fixes the problem?

I'll merge and create a new release after that. Thanks!

@nibanks
Copy link

nibanks commented Jan 27, 2022

@nibanks can you try with uses: laurentsimon/scorecard-action@bug/emptypat and confirm it fixes the problem?

Sorry, I'm not going to be able to have time to test this today.

@laurentsimon
Copy link
Contributor Author

that's fine. Will wait till you ping back. Any ~ETA (EOW, Monday)?

@laurentsimon
Copy link
Contributor Author

friendly ping. Let me know if this has fixed your problem.

@nibanks
Copy link

nibanks commented Feb 1, 2022

I was just able to validate this, it worked as expected: https://github.com/nibanks/msquic/runs/5024203958?check_suite_focus=true.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: GitHub token env var is not set.
3 participants