Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove env vars #112

Merged
merged 12 commits into from Feb 23, 2022
Merged

Remove env vars #112

merged 12 commits into from Feb 23, 2022

Conversation

rohankh532
Copy link
Contributor

@rohankh532 rohankh532 commented Feb 23, 2022 •
edited

issue #107
Moving the following variables in main.go from env vars to native Go vars.

  • 1. SCORECARD_POLICY_FILE
  • 2. SCORECARD_RESULTS_FILE
  • 3. SCORECARD_RESULTS_FORMAT
  • 4. SCORECARD_PUBLISH_RESULTS
  • 5. SCORECARD_BIN
  • 6. ENABLED_CHECKS
  • 7. SCORECARD_PRIVATE_REPOSITORY
  • 8. SCORECARD_DEFAULT_BRANCH
  • 9. SCORECARD_IS_FORK (is currently a function?)

@rohankh532 rohankh532 marked this pull request as ready for review February 23, 2022 03:27
naveensrinivasan
naveensrinivasan approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@naveensrinivasan naveensrinivasan merged commit 07d3fdb into ossf:main Feb 23, 2022
@laurentsimon laurentsimon mentioned this pull request Feb 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveensrinivasan naveensrinivasan naveensrinivasan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohankh532 @naveensrinivasan