Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: always use the default GITHUB_TOKEN for signing #898

Merged
merged 9 commits into from Sep 9, 2022

Conversation

laurentsimon
Copy link
Contributor

Should fix #765 (comment)

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #898 (f0c3908) into main (68bf5b3) will decrease coverage by 1.44%.
The diff coverage is 45.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   63.63%   62.19%   -1.45%     
==========================================
  Files           4        4              
  Lines         231      246      +15     
==========================================
+ Hits          147      153       +6     
- Misses         72       77       +5     
- Partials       12       16       +4     
Impacted Files Coverage Δ
signing/signing.go 35.29% <45.00%> (+0.81%) ⬆️

@laurentsimon laurentsimon enabled auto-merge (squash) September 9, 2022 19:12
@naveensrinivasan
Copy link
Member

@laurentsimon Is this required prior to me releasing the latest version of the action? Let me know

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat, thanks!

Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release: tracking issue for v2.0.0
3 participants