Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Failing API calls to the OpenAPI/Swagger based endpoint #801

Closed
azeemshaikh38 opened this issue Aug 15, 2022 · 4 comments · Fixed by #811
Closed

BUG: Failing API calls to the OpenAPI/Swagger based endpoint #801

azeemshaikh38 opened this issue Aug 15, 2022 · 4 comments · Fixed by #811
Assignees

Comments

@azeemshaikh38
Copy link
Contributor

Related: #792, #793, #794, #795, #796, #798, #799, #800

OpenAPI/Swagger based APIs expect the request to explicitly specify application/json as request header. To fix this I plan to:

  • Rollback the current change so existing users of beta scorecard-action are not affected.
  • Update the e2e tests to talk to the staging API instead of prod, that way we catch these issues before it goes into production.
  • Update scorecard-action calls to use application/json.
@azeemshaikh38
Copy link
Contributor Author

This is now fixed. Keeping it open till I get the e2e tests working.

@azeemshaikh38
Copy link
Contributor Author

@ossf/scorecard-maintainers need some input - for the e2e tests to work on staging API url (so that we catch bugs before they make it into production), I need a way to override the publish URL. I added an env override only to realize that the workflow verification fails (we don't allow env vars to be set in scorecard workflows for result integrity). So thinking of adding publish_base_url to action.yaml. What do folks think?

@laurentsimon
Copy link
Contributor

SGTM.

@azeemshaikh38 azeemshaikh38 linked a pull request Aug 18, 2022 that will close this issue
@laurentsimon
Copy link
Contributor

Let's just hide this variable behind a internal-publish-base-url, so that there's no expectation from users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants