Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Get the Golang code in sync with Bash #489

Merged
merged 1 commit into from Jun 16, 2022
Merged

Conversation

azeemshaikh38
Copy link
Contributor

Part of #156.

This PR fixes parts of the Golang code which were out of sync with Bash (found most of these issues when setting up the e2e tests):

  • Golang does not print out the event info during its run.
  • Adds support for pull_request* event in Golang code.
  • Only runs Branch-Protection check for branch_protection trigger.
  • Adds unit tests for these changes.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #489 (712a1b2) into main (1ca6c49) will decrease coverage by 0.60%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   64.54%   63.94%   -0.61%     
==========================================
  Files           4        4              
  Lines         220      208      -12     
==========================================
- Hits          142      133       -9     
+ Misses         69       66       -3     
  Partials        9        9              
Impacted Files Coverage 螖
options/options.go 88.88% <89.28%> (+1.29%) 猬嗭笍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants