Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ use GITHUB_TOKEN when repo_token is empty on PRs #335

Merged
merged 23 commits into from Jun 27, 2022

Conversation

laurentsimon
Copy link
Contributor

closes #329

action.yaml Outdated Show resolved Hide resolved
action.yaml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #335 (bf5883a) into main (2e062bc) will increase coverage by 0.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   62.99%   63.63%   +0.64%     
==========================================
  Files           4        4              
  Lines         227      231       +4     
==========================================
+ Hits          143      147       +4     
  Misses         72       72              
  Partials       12       12              
Impacted Files Coverage Δ
options/env.go 100.00% <ø> (ø)
options/options.go 84.28% <100.00%> (+0.46%) ⬆️

@laurentsimon laurentsimon enabled auto-merge (squash) June 16, 2022 23:14
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can we do this in Golang code directly now? I think we should stop development on the Bash code at this point. We have fixed most diffs.

@azeemshaikh38
Copy link
Contributor

Actually, can we do this in Golang code directly now? I think we should stop development on the Bash code at this point. We have fixed most diffs.

Or maybe have the same change available in both.

@laurentsimon
Copy link
Contributor Author

Actually, can we do this in Golang code directly now? I think we should stop development on the Bash code at this point. We have fixed most diffs.

Or maybe have the same change available in both.

done. PTAL

@laurentsimon laurentsimon enabled auto-merge (squash) June 16, 2022 23:30
options/options.go Outdated Show resolved Hide resolved
@azeemshaikh38
Copy link
Contributor

Actually, can we do this in Golang code directly now? I think we should stop development on the Bash code at this point. We have fixed most diffs.

Or maybe have the same change available in both.

done. PTAL

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad credentials using ossf/scorecard-action@3e15ea8318eee9b333819ec77a36aca8d39df13e
2 participants