Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve display of results in SARIF #125

Open
laurentsimon opened this issue Mar 2, 2022 · 2 comments
Open

Improve display of results in SARIF #125

laurentsimon opened this issue Mar 2, 2022 · 2 comments

Comments

@laurentsimon
Copy link
Contributor

Some of the text has new lines automatically inserted and does not look good.
@rajbos
Copy link
Contributor

rajbos commented Dec 8, 2022

Examples here:
image

I'd love to help out, but I can't see where the actual messages are coming from. If you point me in the right direction, I'd love to help out!

Edit: seems like these originate in the original project here.

@laurentsimon
Copy link
Contributor Author

laurentsimon commented Dec 8, 2022 •
edited

100% agreed it does not look great. If you can help, that would be wonderful.

The generation of SARIF's text is https://github.com/ossf/scorecard/blob/main/pkg/sarif.go#L579-L582
Other relevant files that get called:
https://github.com/ossf/scorecard/blob/main/docs/checks/impl.go#L50, https://github.com/ossf/scorecard/blob/main/docs/checks/impl.go#L107

Feel free to create an issue on scorecard and close this one. CC me on the PR and I'll review. Thanks!

@rajbos rajbos mentioned this issue Dec 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rajbos @laurentsimon