New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 Bump docker tag for new release. #1055
Conversation
Signed-off-by: Spencer Schrock <sschrock@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the RELEASE.md needs to move the section on testing to after the section on updating the tag.
Until the release happens, the newly tagged Docker image won't exist. So doing it after the tag but before the release also won't work. I think we need a test version of |
Yeah, I meant after release as well. But too late if it's broken.
What is Or we need to cut a |
So right now RELEASE.md mentions a manual dispatch of scorecard-action/.github/workflows/scorecards.yml Lines 23 to 26 in e38b190
But Lines 54 to 56 in e38b190
I think we need to change our test version of
|
Signed-off-by: Spencer Schrock sschrock@google.com
I've manually tested the action, as the steps in RELEASE.md don't actually test any new changes since the docker image is pinned to a version.
I've tested with this command and confirmed the original bug (ossf/scorecard#2557) is fixed.