Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule violation on vulnerability is not getting triggered #189

Closed
saaskesaakura345 opened this issue May 10, 2024 · 3 comments
Closed

Rule violation on vulnerability is not getting triggered #189

saaskesaakura345 opened this issue May 10, 2024 · 3 comments

Comments

@saaskesaakura345
Copy link

Hi Team,

I am facing issues with raising rule violations for vulnerable components in my dependencies.
I am using the existing evaluator.kts file from this repository and it triggers rule violations for license issues but not for vulnerabilities.

As seen below vulnerabilities are identified, but not brought out in the "Rule Violations" tab.
image

The action file used is : https://github.com/oss-review-toolkit/ort-ci-github-action

Can someone guide me to understand what i am missing or any reference to the solution.

@sschuberth
Copy link
Member

As @tsteenbe pointed out, this is probably related to the example rule to only trigger for the CVSS2 scoring system.

@tsteenbe
Copy link
Member

tsteenbe commented May 23, 2024

See for example https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/10/GHSA-67hx-6x53-jw92/GHSA-67hx-6x53-jw92.json#L13 propose we update the rule to trigger for CVSSv3 or make the rule work in a scoring system agnostic way.

@sschuberth
Copy link
Member

update the rule to trigger for CVSSv2

That should say "CVSSv3", I believe.

sschuberth added a commit that referenced this issue May 23, 2024
Resolves #189.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants