Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange BSD License mapping for pytest_cov-2.7.1-py2.py3-none-any.whl #152

Closed
brunopacheco1 opened this issue Dec 11, 2023 · 2 comments
Closed

Strange BSD License mapping for pytest_cov-2.7.1-py2.py3-none-any.whl #152

brunopacheco1 opened this issue Dec 11, 2023 · 2 comments

Comments

@brunopacheco1
Copy link
Contributor

brunopacheco1 commented Dec 11, 2023 •
edited

Summary

I am reviewing licenses with OSS Review Toolkit and this report shows the message below.

pytest_cov is under MIT, but this file pytest_cov-2.7.1-py2.py3-none-any.whl is under BSD License. How is that possible?

Screenshot 2023-12-11 at 13 36 28

Expected vs actual result

Everything should be under MIT. Or we should not check license of .whl files. What do you suggest to do?

Reproducer

Run ORT on a project that depends on pytest_cov==2.7.1.
@brunopacheco1
Copy link
Contributor Author

I finally spent some time checking this issue, and I found the root cause.

If we trace back setup.py at v2.7.1 and can see there was a bug. The overall license is MIT, but in the project metadata was said BSD License.

This was fixed latter on at v2.12.0.

@sschuberth
Copy link
Member

This was addressed by #159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sschuberth @brunopacheco1