Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sqlalchemy-oso's packaging version to support newer / more modern versions of Black #1671

Closed
kkirsche opened this issue Feb 1, 2023 · 1 comment · Fixed by #1672

Comments

@kkirsche
Copy link
Contributor

kkirsche commented Feb 1, 2023

To support updates to tools such as Black, sqlalchemy-oso needs to loosen its packaging dependency restrictions:

Because no versions of black match >23.1.0,<24.0.0
 and black (23.1.0) depends on packaging (>=22.0), black (>=23.1.0,<24.0.0) requires packaging (>=22.0).
And because sqlalchemy-oso (0.26.3) depends on packaging (>=21.3,<22.0)
 and no versions of sqlalchemy-oso match >0.26.3,<0.27.0, black (>=23.1.0,<24.0.0) is incompatible with sqlalchemy-oso (>=0.26.3,<0.27.0).
So, because PROJECT_NAME depends on both sqlalchemy-oso (^0.26.3) and black (^23.1.0), version solving failed.

https://github.com/pypa/packaging/blob/main/CHANGELOG.rst#220---2022-12-07
https://github.com/pypa/packaging/blob/main/CHANGELOG.rst#230---2023-01-08

kkirsche pushed a commit to kkirsche/oso that referenced this issue Feb 1, 2023
@kkirsche kkirsche changed the title Upgrade sqlalchemy-oso's packaging version Upgrade sqlalchemy-oso's packaging version to support newer / more modern versions of Black Feb 1, 2023
@kkirsche
Copy link
Contributor Author

kkirsche commented Feb 1, 2023

https://github.com/psf/black/releases/tag/23.1.0

Black now depends on packaging version 22.0 or later. This is required for new functionality that needs to parse part of the project metadata (psf/black#3219)

@gj gj closed this as completed in #1672 Mar 4, 2023
gj added a commit that referenced this issue Mar 4, 2023
Fixes #1671

Co-authored-by: Gabe Jackson <17556281+gj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant