Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds implementation parts to This System component in markdown #1536

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat: adds implementation parts to This System component in markdown #1536

wants to merge 6 commits into from
+195 −37

Conversation

jpower432
Copy link
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Alters SSP markdown to write the heading for the implementation part if it exists in the control for This System

  • This has been tested with the component markdown to ensure the original behavior is not altered and parts are only written when rules are attached
  • This changes the resulting SSP JSON by adding a This System by-component to a statement for every control part

Closes #1527

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@jpower432
feat: adds implementation part prompts for This System
8e94202 
Changes in assembly are due to changes in the markdown breaking the unit tests
because the This System component is associated with each statement

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
fix: removes this system comp prose and status duplication
cf2c8d7 
The process_main_component was overwriting the first prose
response to all the parts

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: removes TODO comment for bug review
58ff72e 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: updates workding in comments in control_writer.py
e913865 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: moves part_a_text_edited into applicable unit tests
cc966f8 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
Merge branch 'develop' into feat/add-impl-parts-ssp
a1787af
@jpower432 jpower432 marked this pull request as ready for review June 6, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleJo2995 AleJo2995 Awaiting requested review from AleJo2995

@vikas-agarwal76 vikas-agarwal76 Awaiting requested review from vikas-agarwal76

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Implementation part headers by default for main component in SSP Markdown
1 participant
@jpower432