Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when users define system = true in sources #3692

Open
achilleas-k opened this issue Sep 19, 2023 · 2 comments
Open

Warn when users define system = true in sources #3692

achilleas-k opened this issue Sep 19, 2023 · 2 comments

Comments

@achilleas-k
Copy link
Member

achilleas-k commented Sep 19, 2023

Similar to #3435, we should warn when users include system = true in their source toml files that they add through composer-cli sources add source.toml. The system property is meant to indicate that an rpm repo is defined in the system-wide sources (in /usr/share/ or /etc/) instead of in the sources in the store when it's being printed through composer-cli sources info. Users sometimes use the output of the command to define their own source and define the value, expecting it to have an effect.

@ottobackwards
Copy link

It would be nice, if for each file type that could be uploaded, there was a verify call to check it.

@bcl
Copy link
Contributor

bcl commented Sep 27, 2023

It would be nice, if for each file type that could be uploaded, there was a verify call to check it.

They should just be checked when uploaded, as much as possible. The problem you can run into is that some failures can't be known until it is used to build an image. But we should add as much validation on the input as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants